Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-15000: Changes to container image to reduce overall size #575

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

ttuffin
Copy link
Contributor

@ttuffin ttuffin commented Aug 25, 2023

Closes AAP-15000.

The main changes are switching to Centos stream image and installing ansible-core instead of the full ansible package.
Image size is reduced from ~2gb to ~500mb.
Tests in the eda-qa test suite are passing with this image.

@ttuffin ttuffin marked this pull request as draft August 25, 2023 14:36
@ttuffin ttuffin force-pushed the AAP-15000_trim_docker_image branch from 7901005 to f3a9400 Compare August 25, 2023 14:37
@ttuffin ttuffin requested a review from Alex-Izquierdo August 25, 2023 14:38
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Copy link
Contributor

@Alex-Izquierdo Alex-Izquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One way to get more confidence could be run the e2e test suite against this image.

@ttuffin ttuffin changed the title WIP: Changes to container image to reduce overall size Changes to container image to reduce overall size Sep 22, 2023
@ttuffin ttuffin force-pushed the AAP-15000_trim_docker_image branch 3 times, most recently from 8087be0 to 4fba55b Compare September 22, 2023 06:40
@ttuffin ttuffin marked this pull request as ready for review September 22, 2023 06:41
@ttuffin
Copy link
Contributor Author

ttuffin commented Sep 22, 2023

LGTM. One way to get more confidence could be run the e2e test suite against this image.

Tests are passing 👍

@ttuffin ttuffin changed the title Changes to container image to reduce overall size AAP-15000: Changes to container image to reduce overall size Sep 25, 2023
@ttuffin ttuffin requested a review from a team September 25, 2023 09:29
@Alex-Izquierdo
Copy link
Contributor

Lets put on hold this PR until implement a CI workflow to test the image.

@Alex-Izquierdo
Copy link
Contributor

#583

@ttuffin ttuffin marked this pull request as draft November 15, 2023 15:20
@ttuffin ttuffin force-pushed the AAP-15000_trim_docker_image branch 3 times, most recently from dd0ae5c to 0217514 Compare November 15, 2023 16:25
@ttuffin ttuffin marked this pull request as ready for review November 15, 2023 16:33
Alex-Izquierdo
Alex-Izquierdo previously approved these changes Nov 15, 2023
Reduces the overall size from ~2gb to ~500mb
- Use CentOS stream dev image
- Switch from ansible to ansible-core
@ttuffin ttuffin requested a review from a team December 8, 2023 09:24
@ttuffin ttuffin requested a review from a team December 12, 2023 13:19
@ttuffin ttuffin merged commit efde2b3 into main Dec 12, 2023
8 checks passed
@ttuffin ttuffin deleted the AAP-15000_trim_docker_image branch December 12, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants